-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make jenkins/runlocal
platform independent
#3474
Conversation
ubi/ubi:9.1
jenkins/runlocal
platform independent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds plausible. I would definitely support dropping the clean
targets. When I run it repeatedly it's usually because I changed something: but often a functional test and rarely a dashboard file!
# Build the Pbench Server RPM and container, and run functional tests locally. | ||
# Requires a Fedora, CentOS, or RHEL environment to run. | ||
|
||
# | ||
# NOTE WELL: By default, when the functional tests are run, the infrastructure | ||
# pod and Pbench Server container are left running by default. Add the switch, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the "by default"s can go :-), but not necessarily in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to plead, "I didn't change that or any related line", unless you request some other change. 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Well, dang. I rebased against this and now on the install I'm getting
Are we still somehow getting a mismatch between RPM and container? 😦 Sadly, this is a step back for me since I'd been able to |
Do you still have |
Never did put it in my environment. BTW, the old |
This PR changes
jenkins/runlocal
to make it independent of the host distro and version. There is also a change to free thecontainerbuild.sh
script of dependence on a particular tag for theubi9
base image.Note to reviewers: currently
jenkins/runlocal
rebuilds everything from scratch, by first building thedistclean
andclean
targets for the Pbench Server RPM and the Dashboard deployment, respectively, which makes the run take substantially longer and is pointless if there haven't been any changes to the sources. I propose removing those two targets, which will speed up the cycle time. The Make magic should cause those things to be rebuilt if there are changes to them, and the developer also has the option of building those targets manually if s/he wants a fresh build. Thoughts?PBENCH-1181