Provide dataset summary info on upload #3480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbutenhof
added
Server
Dashboard
PBENCH-1204 This stems from a request from the UI to help optimize a partial refresh after using the relay upload dialog, by providing identification of the new dataset. Although a client using the traditional `PUT /upload` already knows the name and MD5, the returned information may be helpful. This is a DRAFT partly because I added a validation of the new information to the functional test, which I've renamed in distributed-system-analysis#3473 ... I'll do that merge here after it's gone in. It's also DRAFT because while I like the idea of including URIs (and in particular this addresses a certain request regarding accessibility of the tarball), I'm not really sure which URIs to include or in what form. I'm certain that one or two people might possibly have opinions on this subject!
Improve `contents` functional test to verify the URI values. Use `location` response header to return the tarball URI in upload, and verify that.
ndokos
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBENCH-1204
This stems from a request from the UI to help optimize a partial refresh after using the relay upload dialog, by providing identification of the new dataset. Although a client using the traditional
PUT /uploadalready knows the name and MD5, the returned information may be helpful.This also reports the tarball download URI (which is the best encapsulation of the results "identity") in the response
locationheader to make it easy to retrieve.