[release/2.7] Fix vndr and check #3001
Conversation
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Codecov Report
@@ Coverage Diff @@
## release/2.7 #3001 +/- ##
============================================
Coverage 60.25% 60.25%
============================================
Files 103 103
Lines 8024 8024
============================================
Hits 4835 4835
Misses 2546 2546
Partials 643 643
Continue to review full report at Codecov.
|
| @@ -5,7 +5,6 @@ | |||
| "EnableGC": true, | |||
| "Enable": [ | |||
| "structcheck", | |||
| "staticcheck", | |||
There was a problem hiding this comment.
@dmcgowan why the removal of static check?
There was a problem hiding this comment.
static check is failing on this branch and it is not requirement. It will remain on the master branch. The number of fixes related to static check is too large to backport imo.
|
Looks like this was because a different versions of vndr was used before; should we pin vndr to a fixed version? |
|
@thaJeztah vndr changes can be annoying, but it doesn't happen very often and is usually a sensible change anyway. Better to just update the code than pin vndr I think. As for staticcheck, I just don't think it is worth figuring all that out on the 2.7 code base, we can in master. |
Signed-off-by: Derek McGowan derek@mcgstyle.net