restore jobs with file

[vision9527]

restore jobs with file

[vision9527]

@Victorcoder
I have removed download api and squash to one commit.

[vcastellm]

Thanks for your work @vision9527 are you still interested in this?

[vision9527]

Thanks for your work @vision9527 are you still interested in this?

I'm just in this case. Respect your design philosophy. It's up to you.

[vcastellm]

Some suggestions and rebase with master please

[vcastellm]

Also modify the swagger.yml spec please.

[vcastellm]

@vision9527 also you will need to fix conflicts

[vision9527]

@Victorcoder done

[vcastellm]

@vision9527 could you write the rationale for creating a job tree. I see some test jobs without dependent jobs. In theory if the jobs were exported with the /jobs endpoint, importing them one by one should end up with a correct structure without having to elaborate such a complex parsing.

[vision9527]

@vision9527 could you write the rationale for creating a job tree. I see some test jobs without dependent jobs. In theory if the jobs were exported with the /jobs endpoint, importing them one by one should end up with a correct structure without having to elaborate such a complex parsing.

Oh, it's my mistake. I change the test jobs code and the endpoint is correct. You can review now. The job tree that has parent job and dependent job can be created with a correct structure. The key is to deal with parent job and dependent job in the endpoint.

[vcastellm]

@vision9527 Shouldn't the enpoint in this comment #654 (comment) be just restore

I will ask it in another way, what will happen if we just do:

// file: api.go
...
var jobs []*Job
err = json.Unmarshal(data, &jobs)

for _, job := range jobs {
  err := a.GRPCClient.SetJob(job)
}
...

[vision9527]

@vision9527 Shouldn't the enpoint in this comment #654 (comment) be just restore

I will ask it in another way, what will happen if we just do:

// file: api.go
...
var jobs []*Job
err = json.Unmarshal(data, &jobs)

for _, job := range jobs {
  err := a.GRPCClient.SetJob(job)
}
...

Abort if parent not found before committing job to the store.
It can't be for sure that the create job sequence is right.
Job tree is a array in which parent job is in the front of the dependent jobs, so it can be sure when the dependent job will be created that parent job is exist.

[vision9527]

@Victorcoder Please review, bro.

[vcastellm]

Many changes in master, please fix conflicts or rebase, and we should be good to go, thanks!

[vision9527]

Many changes in master, please fix conflicts or rebase, and we should be good to go, thanks!

Done.

[vcastellm]

LGTM

[vcastellm]

After reviewing this again, I left some comments

[vcastellm]

LGTM