-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multitag cardinality bug #842
Fix multitag cardinality bug #842
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job here! thx @yvanoers, just one observation, I had a hard time reviewing because filterNodes
function modifies execNodes
inside, this is an unexpected change, I tend to prefer returning the modified structure for clarity, WDYT?
00280f1
to
608c02f
Compare
I made the function return everything it touches. Also reduced the side effect of the tags changing and now returning new value. To really properly fix the lengthiness of these functions, I would create a separate struct with accompanying functions and put it all in a separate file. I didn't want to go that way, though, because it seems like an extensive solution to a relatively small problem. Anyway, I pushed some changes, have a look and let me know your thoughts, @Victorcoder ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks much more intuitive, thanks!
Hi @yvanoers I'm receiving reports of this change affecting the evenly balancing of executions in nodes I did not have verified it myself, but I'm letting you know before looking at it, because if you see a quick fix. |
@Victorcoder Interesting, I'll have a look tonight. |
@yvanoers yes, correct, it changed colors because of node restart, switching leader, jobs are mostly executed on the leader |
@Victorcoder I found the problem, I will create a pull request shortly. |
Fixes #821.