-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace boltdb with fast-store #976
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the comment, LGTM.
But does this change require users to do some kind of migration, or will this work transparently?
Yes @yvanoers this is a breaking change, this is why this will be published in 4.x, you can not upgrade in place but it only requires of a rolling deploy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ok; is there, or will there be documentation on how to do that? I'm unaware of any. |
@yvanoers doc for upgrade strategies here https://dkron.io/usage/upgrade/#rolling-upgrade |
Ah yes, great! |
Superseded by #1172 |
Replacing BoltDB with fast-store increased the speed of the Raft log operations enormously, allowing the user to choose the degree of duration in disk.
Under my tests, with the same degree of duration as boltdb (High) the speed is x2 but using the Mid duration, the default that sync to disk every second, the speed increases tenfold.
Considering that Dkron is not the source of truth for the data it stores, the cost-benefit of using less durability is high.
Note: This will be included in the upcoming v4.x