Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace boltdb with fast-store #976

Closed
wants to merge 4 commits into from
Closed

Replace boltdb with fast-store #976

wants to merge 4 commits into from

Conversation

vcastellm
Copy link
Member

@vcastellm vcastellm commented Jun 6, 2021

Replacing BoltDB with fast-store increased the speed of the Raft log operations enormously, allowing the user to choose the degree of duration in disk.

Under my tests, with the same degree of duration as boltdb (High) the speed is x2 but using the Mid duration, the default that sync to disk every second, the speed increases tenfold.

Considering that Dkron is not the source of truth for the data it stores, the cost-benefit of using less durability is high.

Note: This will be included in the upcoming v4.x

@vcastellm vcastellm added the 4.x label Jun 6, 2021
@vcastellm vcastellm requested a review from yvanoers June 6, 2021 17:16
Copy link
Collaborator

@yvanoers yvanoers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the comment, LGTM.
But does this change require users to do some kind of migration, or will this work transparently?

dkron/agent.go Outdated Show resolved Hide resolved
@vcastellm
Copy link
Member Author

Yes @yvanoers this is a breaking change, this is why this will be published in 4.x, you can not upgrade in place but it only requires of a rolling deploy.

Copy link
Collaborator

@yvanoers yvanoers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yvanoers
Copy link
Collaborator

yvanoers commented Jun 8, 2021

Yes @yvanoers this is a breaking change, this is why this will be published in 4.x, you can not upgrade in place but it only requires of a rolling deploy.

Ok; is there, or will there be documentation on how to do that? I'm unaware of any.

@vcastellm
Copy link
Member Author

@yvanoers doc for upgrade strategies here https://dkron.io/usage/upgrade/#rolling-upgrade

@yvanoers
Copy link
Collaborator

yvanoers commented Jun 9, 2021

Ah yes, great!
And here's a PR to improve some of the text: #980 :)

@vcastellm
Copy link
Member Author

Superseded by #1172

@vcastellm vcastellm closed this Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants