48k ram patch 1 #87
Merged
48k ram patch 1 #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
48kRAM
commented
May 6, 2020
48kRAM
commented
- Add examples in README.md of how to use the space threshold checks with both percentage and byte thresholds.
- Add note in internal help text that multiple thresholds should be comma-separated
- Fix typo in internal help text
The 'no warnings' experimental for smartmatch is only needed on older perl versions. Otherwise it causes issues.
Add note indicating that multiple space thresholds (e.g., % and *B) should be separated with a comma.
Remove extra 'n' in clusternode_health. Thanks bb-Ricardo
|
@48kRAM Ok, as I tested #86 twice and @mbe-financial-com 's pr does still not work I decided to test yours, which works fine, so I'll merge it now, Tx and sry it took so long to merge.. |
Elias481
pushed a commit
to Elias481/check_netapp_ontap
that referenced
this pull request
Sep 24, 2020
* Add examples of using percent and byte thresholds * Don't warn experimental on old perl versions The 'no warnings' experimental for smartmatch is only needed on older perl versions. Otherwise it causes issues. * Note use of comma in space thresholds Add note indicating that multiple space thresholds (e.g., % and *B) should be separated with a comma. * Fix typo in help text Remove extra 'n' in clusternode_health. Thanks bb-Ricardo
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.