Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Prettier in CI via NPM #487

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Run Prettier in CI via NPM #487

merged 1 commit into from
Jul 11, 2023

Conversation

jelovirt
Copy link
Member

@jelovirt jelovirt commented Jul 6, 2023

Description

Run Prettier in GitHub Actions via NPM instead of GA action.

Motivation and Context

Run Prettier check the same way as locally to simplify configuration.

Type of Changes

  • New feature (non-breaking change which adds functionality)

Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
@jelovirt jelovirt added the github_actions Pull requests that update GitHub Actions code label Jul 6, 2023
@jelovirt jelovirt requested a review from infotexture July 6, 2023 13:29
@infotexture infotexture merged commit 614086b into develop Jul 11, 2023
@infotexture infotexture deleted the feature/ci-prettier branch July 11, 2023 21:28
infotexture added a commit to infotexture/dita-bootstrap that referenced this pull request Jul 11, 2023
This syncs changes from dita-ot/docs#487 to simplify configuration by using the same script in CI than runs locally.

It also works around issues with failing Prettier checks when using the latest Prettier versions, which the `creyD/prettier_action` picks up by default.

Using the Prettier version in the package file ensures the same version runs in CI, which allows checks to complete successfully.

Signed-off-by: Roger Sheen <roger@infotexture.net>
infotexture added a commit that referenced this pull request Jul 17, 2023
* develop:
  Edit revised short description
  Update example XSLT and example shortdesc
  Add navtitle & edit XSLT pre-processing use case
  Add plug-in example to transform topics with XSLT after preprocess
  Bump stylelint from 15.6.2 to 15.10.1 (#488)
  Bump lint-staged from 13.2.2 to 13.2.3 (#484)
  Run Prettier in CI via NPM (#487)
  Remove remnants of old stylelint-check
  Fix path to `plugin.properties` (#483)
  Add 4.1 release date
  Move `.git-blame-ignore-revs` to repo root
infotexture added a commit that referenced this pull request Jul 20, 2023
* hotfix/4.1.1:
  Re-use installation instructions in plug-in topics
  Correct version reference in logging bugfix
  Link to № 4250 from dependency listings
  Add details on issues resolved in 4.1.1
  Group dependency updates as in earlier versions
  Add latest issues to 4.1.1 Release Notes stub
  Prepare 4.1.1 Release Notes stub
  Bump Docker image version to ”4.1.1“
  Bump 'maintenance-version' key to “4.1.1”
  Edit revised short description
  Update example XSLT and example shortdesc
  Add navtitle & edit XSLT pre-processing use case
  Add plug-in example to transform topics with XSLT after preprocess
  Bump stylelint from 15.6.2 to 15.10.1 (#488)
  Bump lint-staged from 13.2.2 to 13.2.3 (#484)
  Run Prettier in CI via NPM (#487)
  Remove remnants of old stylelint-check
  Fix path to `plugin.properties` (#483)
  Add 4.1 release date
  Move `.git-blame-ignore-revs` to repo root
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants