Move JS build to Parcel #117
Conversation
jelovirt
added
enhancement
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
jelovirt
force-pushed
the
feature/import
branch
from
89d9216 to
aead80e
Compare
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
|
@infotexture This is one of those "nothing should change" changes. I had to use some workarounds because we're still on Bootstrap 3. Do you think we'd have time and energy to move to Bootstrap 4 soon? |
| @@ -46,7 +41,7 @@ | |||
| "whatwg-fetch": "^3.0.0" | |||
| }, | |||
| "dependencies": { | |||
| "jquery": "^3.3.1", | |||
| "jquery": "^2.2.4", | |||
There was a problem hiding this comment.
Bootstrap 3 requires jQuery 2.
There was a problem hiding this comment.
I had to use some workarounds because we're still on Bootstrap 3.
Do you think we'd have time and energy to move to Bootstrap 4 soon?
👍 Sounds like a good topic for the next hackathon.
The current state of this PR builds cleanly for me with only a single warning:
✨ Built in 14.86s.
js/main.map ⚠️ 1.21 MB 116ms
js/main.js 224.94 KB 14.02s
js/plugins.map 179.27 KB 51ms
js/plugins.js 54.37 KB 14.42s
added 1236 packages in 48.437sI assume the
Is that something we could improve by upgrading Bootstrap & JQuery?
These changes would also require documentation changes. So far we've covered the build process & JavaScript updates in the wiki, but I'm thinking we should probably move this info to a ReadMe and update it there to reflect the new Parcel-based process.
Based on original instructions from site wiki per #117: https://github.com/dita-ot/dita-ot.github.io/wiki/Building-site-output Signed-off-by: Roger Sheen <roger@infotexture.net>
I moved the build instructions to the ReadMe in 445787b. Feel free to merge that into this PR and update the JavaScript instructions to reflect Parcel's workflow for watching & compiling JS files — or summarize in a comment here and I'll expand after merging. |
Move JS build to Parcel and remove Gulp.
Fixes #41
Signed-off-by: Jarno Elovirta jarno@elovirta.com