Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add keep code quality config #56

Merged
merged 13 commits into from
Apr 2, 2024
Merged

add keep code quality config #56

merged 13 commits into from
Apr 2, 2024

Conversation

yabe-diverta
Copy link
Contributor

@yabe-diverta yabe-diverta commented Mar 14, 2024

add

  • husky: on commit check
  • lint-staged
  • prettier
  • eslint
    - stylelint

This PR would have a big impact because once running linter then most of code get changed.

Therefore after all WIP code are merged and seems stable, do:
Once a lot of PRs that has been left get swiped,

  1. git switch ops/code_quality
  2. run clean up command below:
npx prettier "**/*.{js,vue}" --write
npx eslint "**/*.{js,vue}" --fix
npx prettier "assets/**/*.{css,sccs}" --write
# npx stylelint "assets/**/*.{css,scss}" --fix
  1. git commit & push here
  2. merge this PR

Update

stylelint looks overkill.
changed my mind not to use it.

@yabe-diverta yabe-diverta changed the base branch from main to nuxt3 March 14, 2024 15:15
@VortexExpansion
Copy link
Contributor

VortexExpansion commented Mar 25, 2024

To do list

  • Remove prettier from package.json and npm install again
  • Run npx eslint "**/*.{js,vue}" --fix and commit

Sorry, something went wrong.

@yabe-diverta
Copy link
Contributor Author

@VortexExpansion
Sry for back and force again, I think it'd be better to use Prettier for code format.
There are 2 statements which contradict each other, do not use prettier and prettier recommendation 😅
They are maybe changing their policy now, so I will reactivate prettier...
Will revert your latest commit, therefore you don't have clear task for this PR. sry for it again 🙇

@yabe-diverta
Copy link
Contributor Author

@VortexExpansion
Updated, please check 🙇
I did lint,prettier setups & format every files.

@yabe-diverta yabe-diverta marked this pull request as ready for review March 30, 2024 04:43
@VortexExpansion
Copy link
Contributor

Confirmed. Merging ✨

@VortexExpansion VortexExpansion merged commit 909d0fc into nuxt3 Apr 2, 2024
@yabe-diverta yabe-diverta deleted the ops/code_quality branch April 2, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants