Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker builds stopped working after update #209

Closed
codygman opened this issue Mar 23, 2021 · 4 comments
Closed

Docker builds stopped working after update #209

codygman opened this issue Mar 23, 2021 · 4 comments
Labels
upstream concerned with upstream

Comments

@codygman
Copy link
Contributor

codygman commented Mar 23, 2021

This is beeing tracked by NixOS/nixpkgs#36214 (comment) (and closed once resolved) (edit @blaggacao)

This might not even belong here, but in the off chance that rebuilds or reactivation don't fully work correctly and devos does anything special I'm posting it in case.

I updated my dependencies here:

codygman@eedf122

I went to build a docker container I'd built recently got a failure, so I tried getting a shell in the base container and calling the failing command:

❯ docker run -it docker:19.03.13
/ # apk add --no-cache entr git
fetch http://dl-cdn.alpinelinux.org/alpine/v3.12/main/x86_64/APKINDEX.tar.gz
WARNING: Ignoring http://dl-cdn.alpinelinux.org/alpine/v3.12/main/x86_64/APKINDEX.tar.gz: temporary error (try again later)
fetch http://dl-cdn.alpinelinux.org/alpine/v3.12/community/x86_64/APKINDEX.tar.gz
WARNING: Ignoring http://dl-cdn.alpinelinux.org/alpine/v3.12/community/x86_64/APKINDEX.tar.gz: temporary error (try again later)
ERROR: unsatisfiable constraints:
  entr (missing):
    required by: world[entr]
  git (missing):
    required by: world[git]

After a flk work-tower switch at this commit I tried the above again and got the issue.

Upon rebooting though and still at that commit, this happens:

❯ docker run -it docker:19.03.13
/ # apk add --no-cache entr git
fetch http://dl-cdn.alpinelinux.org/alpine/v3.12/main/x86_64/APKINDEX.tar.gz
fetch http://dl-cdn.alpinelinux.org/alpine/v3.12/community/x86_64/APKINDEX.tar.gz
(1/6) Installing entr (4.5-r0)
(2/6) Installing nghttp2-libs (1.41.0-r0)
(3/6) Installing libcurl (7.69.1-r3)
(4/6) Installing expat (2.2.9-r1)
(5/6) Installing pcre2 (10.35-r0)
(6/6) Installing git (2.26.3-r0)
Executing busybox-1.31.1-r19.trigger
OK: 27 MiB in 26 packages

It works.

I wouldn't be surprised if maybe this is an issue similar to this one about socket activation and the correct course of action being creating an issue upstream.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@codygman codygman added the bug Something isn't working label Mar 23, 2021
@codygman
Copy link
Contributor Author

codygman commented Mar 23, 2021

Not related to the root cause for above, but stability of a devos installed application (docker). I'm not sure if devos wants to guarantee sane defaults for something like docker or not, but I also ran into "too many files open" and ended up finding this yet to be merged PR that addresses that issue:

NixOS/nixpkgs#112472

I think devos relies on nixpkgs to set these defaults unless it's something egregious? Actually, I don't know if core even has docker anymore or if it's a goal for community to have sane defaults.

@blaggacao
Copy link
Contributor

blaggacao commented Mar 26, 2021

I think devos relies on nixpkgs to set these defaults unless it's something egregious? Actually, I don't know if core even has docker anymore or if it's a goal for community to have sane defaults.

I don't think it is a bad idea to preempt those changes in the community branch.

In the case those are specific PRs from upstream that we might want to pull in to make devos generally more usable, we should probably defer to
NixOS/nix#3920 (comment)

@nrdxp
Copy link
Collaborator

nrdxp commented Mar 26, 2021

Docker is obviously huge for hackers of all stripes, so ensuring simple usage is certainly a good idea in general. Perhaps a nice test suite to ensure docker is working correctly would be in order, to ensure PRs don't break it.

@blaggacao blaggacao added upstream concerned with upstream and removed bug Something isn't working labels Jun 13, 2021
@blaggacao
Copy link
Contributor

Fix: NixOS/nixpkgs#126777

blaggacao pushed a commit to blaggacao/nixpkgs that referenced this issue Jun 23, 2021
Nowadays most applications require a good amount of inotify watches,
so raise our default to what other distros do. If kernel supports it
enable dynamic setting.

fixes NixOS#36214, NixOS#65001 (re-fix)
- NixOS/nixops#890
- divnix/digga#209

replaces: NixOS#112472
@Pacman99 Pacman99 closed this as completed Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream concerned with upstream
Projects
None yet
Development

No branches or pull requests

4 participants