Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

general: pass self to ./lib & ./hosts #189

Closed
wants to merge 1 commit into from

Conversation

blaggacao
Copy link
Contributor

@blaggacao blaggacao commented Mar 16, 2021

It is generally useful to acess the top level flake from
library functions or hosts. This not only simplifies
the mental model and code but also provides additional
context and not least a handle to the repo source code
in the nix store.

closes #169

bors delegate=@Pacman99

@blaggacao blaggacao mentioned this pull request Mar 16, 2021
@blaggacao
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 16, 2021

🔒 Permission denied

Existing reviewers: click here to make blaggacao a reviewer

@blaggacao
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Mar 16, 2021
@blaggacao
Copy link
Contributor Author

lib/default.nix Outdated Show resolved Hide resolved
@Pacman99
Copy link
Member

Yeah this makes sense, it would be good to get in these changes soon.

@Pacman99
Copy link
Member

Pacman99 commented Mar 16, 2021

I think @nrdxp has to delegate one of us first since they're the repo owner.

It is generally useful to acess the top level flake from
library functions or hosts. This not only simplifies
the mental model and code but also provides additional
context and not least a handle to the repo source code
in the nix store.

closes divnix#169
@blaggacao
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 16, 2021

🔒 Permission denied

Existing reviewers: click here to make blaggacao a reviewer

@bors
Copy link
Contributor

bors bot commented Mar 16, 2021

try

Timed out.

@nrdxp
Copy link
Collaborator

nrdxp commented Mar 16, 2021

Is this a duplicate of #164?

@blaggacao
Copy link
Contributor Author

It is a carve out as direct dependency to #168 and is included in #168 .

I wanted to separate concerns of #164 in order to accentuate and walk through their use cases a little slower.

@Pacman99
Copy link
Member

I would prefer we discuss and merge #164 instead since thats already come up as a requirement for a couple other PR's. I don't see the point in picking apart the different parts of it into seperate PR's that need it.

@nrdxp
Copy link
Collaborator

nrdxp commented Mar 16, 2021

I think @nrdxp has to delegate one of us first since they're the repo owner.

That is correct, delegation happens on a per PR basis. I did give you both access to run bors try though.

@blaggacao
Copy link
Contributor Author

I don't see the point in picking apart the different parts of it into seperate PR's that need it.

It's kind of a review tactic of mine... 😉 Also, #164 had a lot of force pushes which made it hard in my opinion to follow the complete thought process.

This was a dependency of #168 so it was just incorporated.

@blaggacao blaggacao closed this Mar 16, 2021
@blaggacao blaggacao deleted the da/impl-169 branch March 16, 2021 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass 'self' to lib
3 participants