-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
general: pass self
to ./lib
& ./hosts
#189
Conversation
bors r+ |
🔒 Permission denied Existing reviewers: click here to make blaggacao a reviewer |
bors try |
@Pacman99 Is this clarifying force push correct? |
Yeah this makes sense, it would be good to get in these changes soon. |
I think @nrdxp has to delegate one of us first since they're the repo owner. |
It is generally useful to acess the top level flake from library functions or hosts. This not only simplifies the mental model and code but also provides additional context and not least a handle to the repo source code in the nix store. closes divnix#169
bors r+ |
🔒 Permission denied Existing reviewers: click here to make blaggacao a reviewer |
tryTimed out. |
Is this a duplicate of #164? |
I would prefer we discuss and merge #164 instead since thats already come up as a requirement for a couple other PR's. I don't see the point in picking apart the different parts of it into seperate PR's that need it. |
That is correct, delegation happens on a per PR basis. I did give you both access to run |
It's kind of a review tactic of mine... 😉 Also, #164 had a lot of force pushes which made it hard in my opinion to follow the complete thought process. This was a dependency of #168 so it was just incorporated. |
It is generally useful to acess the top level flake from
library functions or hosts. This not only simplifies
the mental model and code but also provides additional
context and not least a handle to the repo source code
in the nix store.
closes #169
bors delegate=@Pacman99