Update evalArgs to match the new planned API #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has now been tested in nix repl and it evaluates all arguments correctly. |
|
So go ahead and log it into |
Pacman99
changed the title
blaggacao
approved these changes
Apr 12, 2021
| The configuration for this config | ||
| ''; | ||
| }; | ||
| externalmodules = mkOption { |
There was a problem hiding this comment.
externalmodules -> externalModules
|
I'll commit some more fixups soon. And I'll send a PR to add the generated docs. |
|
fixups in 2b70cd3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply encodes the public facing portion of the api #232. @blaggacao and I ended up changing the API after some discussion, so this is the most updated version of the planned API.