Implement new api #264
Merged
Implement new api #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaggacao
approved these changes
Apr 26, 2021
Get `self` and `inputs` during construction, and rely on specialArgs.channel for nixos flake
this includes creating multiPkgs, and dropping options already set by fup
have each function take pkgs as an argument, so a nixpkgs isn't created just for pkgs-lib and they support more systems
Only to those with three arguments
drop default channel, it is confusing and complicates api don't take nixos input, using channels is better manually pass names for outputs to improve documentation
This was referenced Apr 26, 2021
Closed
added 12 commits
April 26, 2021 18:29
to follow the new api
this makes more sense since evalArgs is the module and it makes the code cleaner
was only meant for debugging, not meant to be commited
we need to filter out arguments that are added in the devos api also anything thats null in either hostDefaults and hosts has to be removed
also update overrides docs it is a pure devos overlay now, it makes sense to go in overlays
Pacman99
commented
Apr 27, 2021
Comment on lines
+44
to
+49
| overlays = [ | ||
| (devos.lib.pathsIn ./overlays) | ||
| ./pkgs/default.nix | ||
| pkgs.overlay # for `srcs` | ||
| nur.overlay | ||
| ]; |
There was a problem hiding this comment.
lists get flattened for overlays and modules, but not externalModules and hostDefaults.modules.
Pacman99
commented
Apr 27, 2021
this allows host-specific settings to be overriden with mkMerge
Pacman99
commented
Apr 27, 2021
added 2 commits
April 27, 2021 12:52
lock file format isn't very reliable with naming inputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the underlying implementation of the api thats defined in the new
evalArgs, it drops and simplifies a lot of the code in devos.Obsoleted by fup:
packagesBuilder.This includes many other changes to get to the final rebase - explanation is in commit messages.