-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixpkgs update and few fixes #394
base: main
Are you sure you want to change the base?
Conversation
not sure how to properly generate those failing lockfiles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. However could we stay on a release branch for the main dependency?
We'll need to figure out why the manual re-locking is now failing in CI.
@@ -5,7 +5,7 @@ let | |||
mkScript = stage: | |||
nixpkgs.writeScript "lefthook-${stage}" '' | |||
#!${nixpkgs.runtimeShell} | |||
[ "$LEFTHOOK" == "0" ] || ${lib.getExe nixpkgs.lefthook} run "${stage}" "$@" | |||
[ "$LEFTHOOK" == "0" ] || ${lib.getExe nixpkgs.lefthook} run --no-auto-install "${stage}" "$@" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually we could switch to 24.05 since it contains this flag implemented at https://github.com/evilmartians/lefthook/releases/tag/v1.6.11
It's actually pretty obvious and I don't know why it worked in the first place:
|
I (finally) made sure tests run on |
056044b
to
d446022
Compare
d446022
to
f554a77
Compare
also adds some common excludes to treefmt
f554a77
to
d13782e
Compare
std
to nixpkgs onnixos-unstable
and applied a few repo tweaks