Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixpkgs update and few fixes #394

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

nazarewk
Copy link
Contributor

@nazarewk nazarewk commented Oct 17, 2024

  • extracted mdbook to own cell
  • switched std to nixpkgs on nixos-unstable and applied a few repo tweaks

@nazarewk
Copy link
Contributor Author

not sure how to properly generate those failing lockfiles

@nazarewk nazarewk changed the title fix: src/data: #393 by extracting mdbook to own cell nixpkgs update and few fixes Oct 17, 2024
Copy link
Collaborator

@blaggacao blaggacao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. However could we stay on a release branch for the main dependency?

We'll need to figure out why the manual re-locking is now failing in CI.

@@ -5,7 +5,7 @@ let
mkScript = stage:
nixpkgs.writeScript "lefthook-${stage}" ''
#!${nixpkgs.runtimeShell}
[ "$LEFTHOOK" == "0" ] || ${lib.getExe nixpkgs.lefthook} run "${stage}" "$@"
[ "$LEFTHOOK" == "0" ] || ${lib.getExe nixpkgs.lefthook} run --no-auto-install "${stage}" "$@"
Copy link
Contributor Author

@nazarewk nazarewk Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually we could switch to 24.05 since it contains this flag implemented at https://github.com/evilmartians/lefthook/releases/tag/v1.6.11

@nazarewk
Copy link
Contributor Author

We'll need to figure out why the manual re-locking is now failing in CI.

It's actually pretty obvious and I don't know why it worked in the first place:

  1. you update /src/local/flake.lock to match the new ../..
  2. ../.. flake just changed so you need to update /src/local/flake.lock
  3. go back to 1.

@blaggacao
Copy link
Collaborator

blaggacao commented Oct 25, 2024

I (finally) made sure tests run on main: https://github.com/divnix/std/actions/runs/11517292880 — can you rebase?

also adds some common excludes to treefmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants