Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to sea-orm-migration 0.11.3 in migration #68

Merged
merged 1 commit into from
May 2, 2023

Conversation

tgeoghegan
Copy link
Contributor

sea-orm-migration 0.11.2 pulls in a version of tracing-subscriber with a bug that stops migrations from working. See 1, 2, 3 for context.

`sea-orm-migration` 0.11.2 pulls in a version of `tracing-subscriber`
with a bug that stops migrations from working. See [1], [2], [3] for
context.

[1]: https://github.com/SeaQL/sea-orm/releases/tag/0.11.3
[2]: SeaQL/sea-orm#1608
[3]: tokio-rs/tracing#2566
@tgeoghegan tgeoghegan requested review from a team and jbr as code owners May 2, 2023 22:21
@tgeoghegan
Copy link
Contributor Author

Oddly, sea-orm was already at 0.11.3 in the main Cargo.toml, and I'm not sure why dependabot noticed it there and not in migration/Cargo.toml. migration is part of the workspace so dependabot should be able to deal with it. In any case, this bug is blocking me so I want to fix it and not wait for dependabot.

Copy link
Contributor

@jbr jbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yikes! lgtm and this overlaps with the same change in #67, which I'll remove from that PR

@tgeoghegan tgeoghegan merged commit 877430b into main May 2, 2023
@tgeoghegan tgeoghegan deleted the timg/migration-sea-orm-0.11.3 branch May 2, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants