Rename PrepareMessage to PrepareState #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbr
force-pushed
the
prepare-message-to-prepare-state
branch
from
c26fc05 to
e890972
Compare
divergentdave
requested changes
Sep 27, 2022
packages/prio3/src/prio3.ts
Outdated
| @@ -267,7 +267,7 @@ export class Prio3<Measurement> implements Prio3Vdaf<Measurement> { | |||
| return { verifier, jointRand }; | |||
| } | |||
|
|
|||
| private encodePrepareMessage( | |||
| private encodePrepareState( | |||
There was a problem hiding this comment.
This should keep the name encodePrepareMessage. (Technically, we are using this function to encode both prepare message shares and prepare messages, but these have the same concrete type and encoding in the context of Prio3)
packages/prio3/src/prio3.ts
Outdated
| @@ -242,7 +242,7 @@ export class Prio3<Measurement> implements Prio3Vdaf<Measurement> { | |||
| : await this.decodeHelperShare(aggregatorId, encoded); | |||
| } | |||
|
|
|||
| private decodePrepareMessage(input: Buffer): { | |||
| private decodePrepareState(input: Buffer): { | |||
There was a problem hiding this comment.
Likewise, this should keep the name decodePrepareMessage.
packages/vdaf/src/index.ts
Outdated
| | { outputShare: OutputShare }; | ||
|
|
||
| prepSharesToPrepareMessage( | ||
| prepSharesToPrepareState( |
There was a problem hiding this comment.
This should keep the name prepSharesToPrepareMessage. See https://cfrg.github.io/draft-irtf-cfrg-vdaf/draft-irtf-cfrg-vdaf.html#section-5.2-6.3
jbr
force-pushed
the
prepare-message-to-prepare-state
branch
2 times, most recently
from
20ff3d2 to
909303b
Compare
Pull Request Test Coverage Report for Build 3161133892Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
jbr
force-pushed
the
prepare-message-to-prepare-state
branch
from
909303b to
2a48674
Compare
divergentdave
approved these changes
Oct 3, 2022
Co-authored-by: David Cook <dcook@letsencrypt.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #31
based on #34