Always enable hpke/std feature (was: Re-expose hpke/std feature)
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divergentdave
approved these changes
Jul 28, 2022
|
Are there known circumstances in users of this crate wouldn't want this enabled? Are people using this crate in a no-std context? |
|
Unless we explicitly want to make sure we support no-std rust, I'd be inclined just to add this feature for everyone for now. |
|
So you're arguing to do this instead: ...and continue to use |
|
Yeah exactly that. One fewer feature for users to have to toggle back on (assuming they probably want it on) |
Unconditionally enable `hpke`'s `std` feature so that `hpke-dispatch` clients who use `default-features = false` can still get the `std::error::Error` implementation on `HpkeError`.
tgeoghegan
force-pushed
the
timg/hpke-std-feature
branch
from
a697b9a to
145db44
Compare
tgeoghegan
changed the title
hpke/std featurehpke/std feature (was: Re-expose hpke/std feature)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a feature
hpke-stdwhich enables featurestdon cratehpke.This allows
hpke-dispatchclients who usedefault-features = falseto re-enable
hpke/stdalongside whatever KEMs, KDFs and AEADs theywant.