Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop wee_alloc dependency #18

Merged
merged 1 commit into from
Sep 29, 2022
Merged

drop wee_alloc dependency #18

merged 1 commit into from
Sep 29, 2022

Conversation

tgeoghegan
Copy link
Contributor

wee_alloc is unmaintained (1), which is generating security advisories on hpke-dispatch and projects that depend on it. AFAIK, there's no alternative to it that is much better supported, so we drop the dependency altogether and use the std allocator.

`wee_alloc` is unmaintained ([1]), which is generating security
advisories on `hpke-dispatch` and projects that depend on it. AFAIK,
there's no alternative to it that is much better supported, so we drop
the dependency altogether and use the std allocator.

[1]: rustwasm/wee_alloc#107
@tgeoghegan tgeoghegan requested review from a team and jbr as code owners September 29, 2022 20:50
Copy link
Contributor

@jbr jbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable to me!

Copy link
Contributor

@divergentdave divergentdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For what it's worth, pkg/web/hpke_dispatch_bg.wasm size went from 393K to 392K with this change. Maybe std's allocator has gotten better in the past couple years.

@jbr
Copy link
Contributor

jbr commented Sep 29, 2022

It would make sense to release this in conjunction with #17 as 0.4.0, since I wasn't entirely sure if #17 was a breaking change on its own

@tgeoghegan tgeoghegan merged commit e98691b into main Sep 29, 2022
@tgeoghegan tgeoghegan deleted the timg/no-more-wee-alloc branch September 29, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants