Vdaf::prepare_preprocess
lacks Vdaf::AggregationParam
argument
#670
Labels
Vdaf::prepare_preprocess
lacks Vdaf::AggregationParam
argument
#670
Trait
Aggregator: Vdaf
has:However, VDAF-06 defines
Vdaf.prep_shares_to_prep(agg_param: AggParam, prep_shares: Vec[Bytes]) -> Bytes
. (VDAF). Note theagg_param
argument that does not appear in our Rust implementation.We get away with this because
Prio3.prep_shares_to_prep
never uses the aggregation parameter. But I'm more confused by the Poplar1 side: the reference implementation ofPoplar1.prep_shares_to_prep
takes responsibility for decoding field elements from bytes and so needs to know what level of the tree it's on, but libprio's implementation seems to have long since decoded everything. I'm not certain what's going on, but it's difficult to reconcile it with the specification.Even if there's some clever trick here that makes Poplar1 work out, it seems like crate
prio
's interface should match up with the specification.The text was updated successfully, but these errors were encountered: