Align agg param encoding for Poplar1 with VDAF-13 #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
force-pushed
the
cjpatton/1122-idpf-agg-param-encoding
branch
from
832622d to
a85142f
Compare
cjpatton
commented
Dec 18, 2024
cjpatton
commented
Dec 18, 2024
cjpatton
force-pushed
the
cjpatton/1122-idpf-agg-param-encoding
branch
from
a85142f to
183db18
Compare
cjpatton
commented
Dec 18, 2024
The encoding of the prefixes has been simplified by avoiding splitting a prefix across a byte boundary. Each prefix is now zero-padded to the next byte. Also, re-enable test vectors for Poplar1 and IDPF.
cjpatton
force-pushed
the
cjpatton/1122-idpf-agg-param-encoding
branch
from
183db18 to
51fa05a
Compare
divergentdave
approved these changes
Dec 19, 2024
This was referenced Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #1122.
The encoding of the prefixes has been simplified by avoiding splitting a prefix across a byte boundary. Each prefix is now zero-padded to the next byte.
Also, re-enable test vectors for Poplar1 and IDPF.