Mastic clean up #1187
Open
Mastic clean up #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
force-pushed
the
cjpatton/947-7-prep-state-serialization
branch
from
6e1662f to
530053d
Compare
Some tests in the `mastic` module generate verification keys that aren't actually used by the test. Incidentally, the same tests were generating keys of the wrong length.
Add a function that computes the length of the aggregate share in field elements as a function of the aggregation parameter.
Avoid iterating over the weights to compute the length of the encoded public share; just take the length of the first weight and multiply by the number of correction words. This computation assumes the length of each weight is equal to the weight parameter at ever level of the VIDPF tree. This certainly is true, but add a test to validate this assumption anyway.
This method is currently implemented for `Vidpf<VidpfWeight<F>>`, but it applies to the more general `Vidpf<W>`.
This method is used in Prio3 and Poplar1 for domain separation with the version of the document that specifies them. This version control is not applicable to future VDAFs defined by future documents. Remove the method from the trait and add it to implementations of `Prio3` and `Poplar1`.
cjpatton
force-pushed
the
cjpatton/947-8-cleanup
branch
from
d4a7bfc to
cb024c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #1185.
Partially addresses #947.
Various clean up things in the wake of finishing Mastic. Review commit-by-commit.