Fix ignored clippy::needless_range_loop lints #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves Prio2 sharding benchmarks on large inputs by about a percent.
These had a negligible effect on benchmark performance.
This saves a couple percent in FFT benchmarks
tgeoghegan
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Chris argued that the C-style loops are easier to resolve against the papers, but I prefer to embrace Rust style (and fervently pray that cryptography papers and specifications will stop using C or Python inspired pseudocode). And I don't think we can argue with the performance improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrites various loops in Prio2 and Prio3 code to address ignored
clippy::needless_range_looplints. This improves some benchmarks by 2%-3%. None of the benchmarks regressed.