Add helpers to get 0/1 as integer associated types #819
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new methods
zero_integer()
andone_integer()
toFieldElementWithInteger
. These replace an existing pattern of constructing zero or one with a round trip through the Montgomery representation, by constructing it as a field element first, and then converting it back. This preparatory work for addressing #643.I considered and rejected creating a new trait for integers, and putting these methods there, because adding a new trait bound to the
Integer
associated type would be a breaking change. We could reconsider this API design the next time we make significant breaking changes.