Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xof: Make the SeedStreamAes128 constructor public #846

Merged
merged 1 commit into from
Nov 22, 2023
Merged

xof: Make the SeedStreamAes128 constructor public #846

merged 1 commit into from
Nov 22, 2023

Conversation

cjpatton
Copy link
Collaborator

No description provided.

@cjpatton cjpatton requested a review from a team as a code owner November 22, 2023 17:54
divergentdave
divergentdave approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@divergentdave divergentdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. It's strange that we had SeedStreamAes128 public, but made constructing one impossible since removing PrgAes128.

@divergentdave divergentdave merged commit 125020f into main Nov 22, 2023
6 checks passed
@divergentdave divergentdave deleted the cjpatton/xof-seed-stream-aes128-constructor branch November 22, 2023 18:21
@inahga
Copy link
Contributor

inahga commented Nov 22, 2023

n.b. looking at SeedStreamSha3 and SeedStreamFixedKeyAes128 they don't appear to be publicly constructable either.

@divergentdave
Copy link
Collaborator

Yes, those two aren't directly constructable, but they are produced by their respective Xof (née Prg) types, after hashing inputs.

@inahga
Copy link
Contributor

inahga commented Nov 22, 2023

Ah I see, I didn't catch that SeedStreamAes128 didn't have a matching Xof type.

@cjpatton cjpatton mentioned this pull request Nov 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divergentdave divergentdave divergentdave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjpatton @inahga @divergentdave