Improve FLP testing and add tooling to "test-util" #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
commented
Jan 11, 2024
cjpatton
force-pushed
the
cjpatton/898
branch
2 times, most recently
from
c1e3ff0 to
8cf7f2b
Compare
Implement a new struct, `flp::test_util::FlpTest`, for driving generic tests for FLPs. This tool subsumes most of the functionality of `flp_validity_test()`. The irregular length tests have been dropped such that the `valid()` is no longer required to do bounds checking itself. Remove `flp_validity_test()` and replace each use with `FlpTest`.
cjpatton
force-pushed
the
cjpatton/898
branch
from
8cf7f2b to
64f76fa
Compare
tgeoghegan
reviewed
Jan 11, 2024
|
|
cjpatton
force-pushed
the
cjpatton/898
branch
2 times, most recently
from
9247c8e to
a1bc281
Compare
divergentdave
approved these changes
Jan 11, 2024
Re-implement `random_vector()` with `XofTurboShake128` so that we don't have to enable the "crypto-dependencies" feature to use it. The current implementation uses `SeedStreamAes128`, which is necessarily behind this feature.
cjpatton
force-pushed
the
cjpatton/898
branch
from
a1bc281 to
293e926
Compare
tgeoghegan
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #898.
Implement a new struct,
flp::test_util::FlpTest, for driving generic tests for FLPs. This tool subsumes most of the functionality offlp_validity_test(). The irregular length tests have been dropped such that thevalid()is no longer required to do bounds checking itself.Remove
flp_validity_test()and replace each use withFlpTest.