feat: update navbar ui with main project site #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
divyanshugarg36
commented
Aug 24, 2022
divyanshugarg36
commented
- update favicon
- remove empty sidebar
added 2 commits
August 24, 2022 22:54
- update favicon - remove empty sidebar
- add social icon svg
theamanjs
requested changes
Aug 25, 2022
There was a problem hiding this comment.
@divyanshugarg36 I think we have to wrap the page with some padding on the sides. On the larger screens, it's now hard to focus on the text. I'm attaching a screenshot of difference.
New updated UI
Old UI of documentation
@theamanjs Yeah I saw this situation on bigger screens so to fix this problem I have added a limit to the total width of content and now it looks good |
theamanjs
approved these changes
Sep 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.