Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update clap version to ^4.5 #466

Merged
merged 1 commit into from
May 27, 2024
Merged

update clap version to ^4.5 #466

merged 1 commit into from
May 27, 2024

Conversation

AldanTanneo
Copy link
Contributor

No description provided.

@diwic
Copy link
Owner

diwic commented May 27, 2024

Hi,

I don't see why not, but it needs to be rebased on top of your other patch, which I just merged.

Btw, what is the main reason for this change/upgrade?

@AldanTanneo
Copy link
Contributor Author

The current clap version that is used is very old and unmaintained, so keeping it up to date seemed wise

Also, some of the dependencies used by clap v2 are currently unmaintained or have security advisories

@diwic
Copy link
Owner

diwic commented May 27, 2024

The current clap version that is used is very old and unmaintained, so keeping it up to date seemed wise

Also, some of the dependencies used by clap v2 are currently unmaintained or have security advisories

Okay. Rebase it and I'll merge it. Thanks!

@diwic diwic merged commit 6ba9b82 into diwic:master May 27, 2024
8 checks passed
@AldanTanneo AldanTanneo deleted the update-clap branch May 27, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants