[FIX] account_reconcile_oca : foreign currency reconcile with late currency rate #3
Conversation
…rrency rate It is possible that the statement line in foreign currency is created before the rate of the day is updated in Odoo. In this case we need to take the real rate of the statement line to comput the exchange rate
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 16.0-fix-mcurr #3 +/- ##
=================================================
Coverage ? 85.86%
=================================================
Files ? 77
Lines ? 3092
Branches ? 441
=================================================
Hits ? 2655
Misses ? 325
Partials ? 112 ☔ View full report in Codecov by Sentry. |
| self.manual_line_id.exists() | ||
| and self.manual_line_id | ||
| and self.manual_kind != "liquidity" | ||
| ): |
There was a problem hiding this comment.
Here, we may have a better fix I don't know, but here it was it fixes :
When you click on the statement line (the liquidity line), _onchange_manual_reconcile_reference is called (to fill all manual fields from what I understand) and then in cascasde _onchange_manual_amount_in_currency is called and it recompute the manual_amount.
So, if the rate of the statement line is different from the current odoo rate at this date, the amount in company currency changes... (and become inconsitent with the real account move line amount)
I don't see any case when it should recompute the amount of the liquidity line.
| @@ -1050,6 +1055,12 @@ def _get_exchange_rate_amount(self, amount, currency_amount, currency, line): | |||
| self.date, | |||
| ) | |||
| to_amount = self.company_id.currency_id.round(to_amount_company_currency) | |||
| elif self.currency_id == currency and not self.foreign_currency_id: | |||
There was a problem hiding this comment.
To compute the exchange amount, I take the "accounting rate", instead of the odoo rate, even if the foreign currency is not filled (case of journan in foreign currency)
It is possible that the statement line in foreign currency is created before the rate of the day is updated in Odoo. In this case we need to take the real rate of the statement line to compute the exchange rate
@etobella One more fix about multi currency.
To reproduce :
Create a rate for d-2
Create an invoice in currency for d-2
Create a statement line in a foreign currency journal for d-1 (same amount in same currency of the invoice)
create a rate for d-1
Try to reconcile => It does not work because the rate of the statement line is the one of d-2.