Fixed toggle function ignoring whitespace #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The togglePlaceholderForInput function decides wether to display or hide the placeholder by trimming the input value and checking it's length. If it's 0 the placeholder is displayed, otherwise it's hidden. The issue here is that by trimming the value, we can confuse the user because we ignore the actual value. For example if the value a bunch of spaces, we will show the placeholder like there's noting there, even though the user might be able to submit it. If whitespace is not a valid value, then the developer should use some validation mechanism to prevent it from being submitted and alert the user. It shouldn't be the responsibility of a placeholder plugin. Here's a Codepen without the fix with a value made up of spaces (click on "Submit" to see what I mean): http://codepen.io/anon/pen/bJBtL Here's a Codepen with the fix: http://codepen.io/anon/pen/kDABj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The togglePlaceholderForInput function decides wether to display or hide the placeholder by trimming the input value and checking it's length. If it's 0 the placeholder is displayed, otherwise it's hidden.
The issue here is that by trimming the value, we can confuse the user because we ignore the actual value. For example if the value is a bunch of spaces, we will show the placeholder like there's noting there, even
though the user might be able to submit it.
If whitespace is not a valid value, then the developer should use some validation mechanism to prevent it from being submitted and alert the user. It shouldn't be the responsibility of a placeholder plugin.
Here's a Codepen without the fix with an initial value made up of spaces (click on "Submit" to see what I mean):
http://codepen.io/anon/pen/bJBtL
And here's a Codepen with the fix (with the same initial value):
http://codepen.io/anon/pen/kDABj