Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macOS as CI target. #26

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Add macOS as CI target. #26

merged 1 commit into from
Jan 22, 2024

Conversation

sodul
Copy link
Contributor

@sodul sodul commented Jan 18, 2024

We have a test failure on Windows so this will have to be addressed separately.

@sodul
Copy link
Contributor Author

sodul commented Jan 18, 2024

On Windows:

    def __new__(cls, *args, **kwargs):
        if cls is Path:
            cls = WindowsPath if os.name == 'nt' else PosixPath
        self = cls._from_parts(args, init=False)
        if not self._flavour.is_supported:
>           raise NotImplementedError("cannot instantiate %r on your system"
                                      % (cls.__name__,))
E           NotImplementedError: cannot instantiate 'PosixPath' on your system

c:\hostedtoolcache\windows\python\3.8.10\x64\lib\pathlib.py:1044: NotImplementedError
=========================== short test summary info ===========================
FAILED tests/test_main.py::test_defaults - NotImplementedError: cannot instan...

https://github.com/clumio-oss/gray/actions/runs/7575939826/job/20633665303

This is probably easily fixable but I do not have access to a Windows machine to look into it more deeply.

Copy link
Contributor Author

@sodul sodul Jan 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I fixed the whitespace so look at the diff with whitespace hidden.

image

@dizballanze dizballanze merged commit db68d94 into dizballanze:master Jan 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants