Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some stuff to prevent connection errors #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

57uff3r
Copy link

@57uff3r 57uff3r commented Sep 15, 2014

Hi!

We use this library in our application and we send thousands of push notifications every day.
And quite often we received connection errors. I added some socket connection options to prevent connection errors. With this options we didn't get any connection errors for almost two weeks.

@djacobs
Copy link
Owner

djacobs commented Sep 16, 2014

Thanks, @57uff3r

@ExplodingCabbage
Copy link
Collaborator

This looks like it probably does something worthwhile and would be good to get merged, but I know @djacobs is pretty conservative about merging anything that he doesn't understand and there's some reasonably complicated shit going on in here.

@57uff3r, if you still remember this stuff, could you summarize the changes here and what they do? What does each of the settings here do and why do you need to only do some of them on non-Darwin OSes? Is that Darwin check some sort of standard, documented recipe that you can cite somebody recommending? If not, what's the rationale behind it; what does it avoid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants