Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow copy with empty suffix #1386

Merged
merged 6 commits into from
Jul 13, 2023

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Jul 12, 2023

Description

The copy files and folders admin form allows for a suffix to be entered, which is placed in the filename of the copied file between the base name and the extension.

This PR allows for empty suffices, i.e. the standard case of no change in filename.

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #1386 (ce5957a) into master (71d16ca) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1386   +/-   ##
=======================================
  Coverage   73.98%   73.98%           
=======================================
  Files          75       75           
  Lines        3436     3436           
  Branches      552      552           
=======================================
  Hits         2542     2542           
  Misses        722      722           
  Partials      172      172           
Impacted Files Coverage Δ
filer/admin/forms.py 68.29% <100.00%> (ø)

@vinitkumar vinitkumar merged commit fdd4d64 into django-cms:master Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants