-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Respect custom filer and thumbnail storage settings #1413
fix: Respect custom filer and thumbnail storage settings #1413
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1413 +/- ##
==========================================
+ Coverage 74.83% 75.00% +0.17%
==========================================
Files 75 75
Lines 3449 3449
Branches 554 554
==========================================
+ Hits 2581 2587 +6
+ Misses 698 694 -4
+ Partials 170 168 -2
|
@fsbraun Is it possible to write tests to verify the regression and the fix? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@vinitkumar You're right: I'll add a test! The missing test is the reason we missed this in the first place. |
Description
This PR fixes issue #1412: It respects custom filer private and public storage settings.
Related resources
Checklist
master
Slack to find a “pr review buddy” who is going to review my pull request.