Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Respect custom filer and thumbnail storage settings #1413

Merged
merged 17 commits into from
Aug 22, 2023

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Aug 20, 2023

Description

This PR fixes issue #1412: It respects custom filer private and public storage settings.

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun mentioned this pull request Aug 20, 2023
2 tasks
@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Merging #1413 (b850c62) into master (d473d20) will increase coverage by 0.17%.
Report is 1 commits behind head on master.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #1413      +/-   ##
==========================================
+ Coverage   74.83%   75.00%   +0.17%     
==========================================
  Files          75       75              
  Lines        3449     3449              
  Branches      554      554              
==========================================
+ Hits         2581     2587       +6     
+ Misses        698      694       -4     
+ Partials      170      168       -2     
Files Changed Coverage Δ
filer/fields/multistorage_file.py 88.34% <ø> (ø)
filer/templatetags/filer_admin_tags.py 89.38% <75.00%> (ø)
filer/__init__.py 100.00% <100.00%> (ø)
filer/urls.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@fsbraun fsbraun requested a review from a team August 20, 2023 18:47
@vinitkumar
Copy link
Member

@fsbraun Is it possible to write tests to verify the regression and the fix?

Copy link
Member

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fsbraun
Copy link
Member Author

fsbraun commented Aug 21, 2023

@vinitkumar You're right: I'll add a test! The missing test is the reason we missed this in the first place.

@fsbraun fsbraun merged commit 3940e1c into django-cms:master Aug 22, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants