Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unique url names for file icon #1423

Merged
merged 10 commits into from
Sep 19, 2023

Conversation

fsbraun
Copy link
Sponsor Member

@fsbraun fsbraun commented Sep 18, 2023

Description

ImageAdmin is a subclass of FileAdmin. get_url of file admin needs to include the admin's model name into the file icon url name.

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (dbeda3a) 75.22% compared to head (6b7d1ce) 75.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1423   +/-   ##
=======================================
  Coverage   75.22%   75.22%           
=======================================
  Files          75       75           
  Lines        3455     3455           
  Branches      555      555           
=======================================
  Hits         2599     2599           
  Misses        691      691           
  Partials      165      165           
Files Changed Coverage Δ
filer/admin/fileadmin.py 94.50% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fsbraun fsbraun requested a review from a team September 18, 2023 16:05
@vinitkumar vinitkumar merged commit c3ab24b into django-cms:master Sep 19, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants