Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add django 5.0 support #1424

Merged
merged 17 commits into from
Sep 22, 2023
Merged

Conversation

fsbraun
Copy link
Sponsor Member

@fsbraun fsbraun commented Sep 19, 2023

Description

This PR adds Django 5.0 support to django-filer:

  • Replace use of Form's undocumented _html_output (removed in Django 5.0) by officially documented AdminForm API (regression test added)
  • Replace removed django.core.file.storages.get_storage_class
  • Add tests for Django 5.0
  • Remove filter_horizontal from ClipboardAdmin (which is inaccessible to the user)
  • Adjust admin reverse for swapped image model in tests

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 92.30% and project coverage change: +0.74% 🎉

Comparison is base (dbeda3a) 75.22% compared to head (5142fbc) 75.96%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1424      +/-   ##
==========================================
+ Coverage   75.22%   75.96%   +0.74%     
==========================================
  Files          75       75              
  Lines        3455     3454       -1     
  Branches      555      554       -1     
==========================================
+ Hits         2599     2624      +25     
+ Misses        691      669      -22     
+ Partials      165      161       -4     
Files Changed Coverage Δ
filer/admin/clipboardadmin.py 94.66% <ø> (-0.08%) ⬇️
filer/admin/folderadmin.py 78.69% <ø> (+3.04%) ⬆️
filer/admin/forms.py 80.48% <91.66%> (+12.19%) ⬆️
filer/settings.py 81.55% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vinitkumar vinitkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's get this merged and released 🚢 🚀

@vinitkumar vinitkumar merged commit 69893eb into django-cms:master Sep 22, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants