fix: URL action in data table list template #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsbraun
approved these changes
Sep 25, 2023
|
This solves #1427 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the CMS admin, when listing the files, we have up to 4 action buttons, with the two firsts "URL" & "Download".
Before this change : Both were links (one canonical, one to the file in media).
Now both are download links.
IMHO :
It became more difficult to display the file in the browser without downloading it. (Now only "right click > open url" allows it.)
So this PR fixes this accordingly.
Also, I noted that the feature name adding the bug was "Styling update", but this change was more a behavior update, I think. So I didn't add anything to the changelog of my PR because it's more "going back to the documented state". However, it might be relevant to document somewhere that the previous version added the download attribute on the download link.