Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

method clean_subject_location not implemented correctly #1465

Merged
merged 1 commit into from
May 17, 2024

Conversation

jrief
Copy link
Collaborator

@jrief jrief commented May 17, 2024

Description

Sorry, this a patch to pull request #1464 which was merged too fast.

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@fsbraun
Copy link
Member

fsbraun commented May 17, 2024

@jrief You merge it when ready ;-)

@jrief
Copy link
Collaborator Author

jrief commented May 17, 2024

I'd also like to build version 3.1.2. The latest version is from 6 months ago, and since then a few other patches have accumulated.

@jrief jrief merged commit 4d3e004 into master May 17, 2024
82 checks passed
@fsbraun
Copy link
Member

fsbraun commented May 17, 2024

@jrief Let me try to get a fix for #1463 in today or tomorrow...

@vinitkumar vinitkumar deleted the fix-clean_subject_location branch November 15, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants