fix: uploadButton data-max-filesize attribute is not passed to file-uploader #1503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attribute exists on the upload button, but it is not read and used.
This PR fix
upload-button.js
to read the value tranform from MiB to bytes and pass the param to FileUploaderBasic object.By the way, the library used is more than 10 years old of age (2011 ?) and is not even maintained since 2018 (repo archived)
Also it is strange to have 2 distinct upload mechanisms, one for dropzone and one for upload button.
master
Slack to find a “pr review buddy” who is going to review my pull request.