fix: incompatibility with djangocms-versioning-filer 1.3 was fixed

[fscherf]

When used with djangocms-versioning-filer, the FileAdminChangeForm might not have a file field due to missing permissions.
Since djangocms-versioning-filer 1.3 the constructor of FileAdminChangeForm crashes when opening the change URL of a published image.

This patch fixes this issue by adding a check whether the file field is present before overriding it.

Description

Checklist

• I have opened this pull request against master
• I have added or modified the tests when changing logic
• I have followed the conventional commits guidelines to add meaningful information into the changelog
• I have read the contribution guidelines and I have joined #workgroup-pr-review on
  Slack to find a “pr review buddy” who is going to review my pull request.

Summary by Sourcery

Fix compatibility issue with djangocms-versioning-filer 1.3 by ensuring the FileAdminChangeForm does not crash when the file field is missing due to permissions.

Bug Fixes:

• Fix crash in FileAdminChangeForm constructor when used with djangocms-versioning-filer 1.3 by checking for the presence of the file field before overriding it.

Tests:

• Modify tests to accommodate the logic change in FileAdminChangeForm.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR fixes a compatibility issue with djangocms-versioning-filer 1.3 by adding a conditional check before modifying the file field widget in the FileAdminChangeForm. The change prevents the form from crashing when the file field is not present due to missing permissions.

Class diagram for FileAdminChangeForm modification

classDiagram
    class FileAdminChangeForm {
        +__init__(*args, **kwargs)
        +clean()
    }
    note for FileAdminChangeForm "Added conditional check for 'file' field presence before setting widget"

Loading

File-Level Changes

Change	Details	Files
Added a defensive check before modifying the file field widget	Added a conditional check to verify if 'file' exists in form fields Only set the FileInput widget when the file field is present	filer/admin/fileadmin.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @fscherf - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}