Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

djangocms-frontend and djangocms-link LinkPlugin conflict #218

Open
planrich opened this issue May 22, 2024 · 2 comments
Open

djangocms-frontend and djangocms-link LinkPlugin conflict #218

planrich opened this issue May 22, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@planrich
Copy link

planrich commented May 22, 2024

We run a 3.11 cms installation and I have recently added the djangocms-frontend.

When attaching a PicturePlugin (frontend) to a placeholder, it explodes on the line

return admin_reverse("link_link_autocomplete")

admin_reverse("link_link_autocomplete") cannot be reversed.

It seems that having the djangocms-link plugin installed, which is earlier loaded in the INSTALLED_APPS does not make the condition true located here:

https://github.com/django-cms/djangocms-frontend/blob/64bca5e34d5f2ee7c86685839db9672b182b9b16/djangocms_frontend/contrib/link/cms_plugins.py#L116C1-L119C44

Blocking frontend to add its own LinkPlugin.

Should it be possible to to run the two plugins (djangocms-frontend and djangocms-link) at the same time?
Is either one of those deprecated? In which project should it be fixed, or migrated to?

@fsbraun
Copy link
Member

fsbraun commented May 22, 2024

@planrich Thanks for pointing this out!

  1. djangocms_link and djangocms_frontend.contrib.link cannot be installed at the same time.
  2. If both appear in INSTALLED_APPS djangocms-frontend is supposed to give the way for djangocms-link.
  3. This, however, should not affect other djangocms-frontend plugins, like the image plugin.

Most people use djangocms-frontend's link plugin instead of djangocms-link. But that's not always practical for existing projects.

A quick fix might be downgrading to djangocms-frontend==1.3.1 (untested).

@fsbraun fsbraun added the bug Something isn't working label May 22, 2024
@fsbraun
Copy link
Member

fsbraun commented Jul 11, 2024

Will rename link plugin as of version 2 of djangocms-frontend to help avoid the conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants