Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rename link plugin to text link plugin #219

Merged
merged 67 commits into from
Jul 11, 2024

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented May 28, 2024

This PR renames the LinkPlugin to TextLinkPlugin.

  • Existing plugins are migrated
  • Now, both djangocms-link and djangocms-frontend's link can be installed side by side

Helps solving #218

Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.58%. Comparing base (f11feee) to head (1fe1457).
Report is 41 commits behind head on master.

Files with missing lines Patch % Lines
djangocms_frontend/contrib/link/cms_plugins.py 66.66% 0 Missing and 1 partial ⚠️
djangocms_frontend/contrib/link/forms.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #219      +/-   ##
==========================================
- Coverage   86.93%   86.58%   -0.35%     
==========================================
  Files         120      120              
  Lines        3107     3116       +9     
  Branches      330      333       +3     
==========================================
- Hits         2701     2698       -3     
- Misses        304      316      +12     
  Partials      102      102              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fsbraun fsbraun merged commit 43ae345 into django-cms:master Jul 11, 2024
45 of 47 checks passed
@fsbraun fsbraun deleted the feat/rename_link branch July 11, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant