-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for djangoCMS 4.x #226
Conversation
This PR supersedes #201 |
Oh man I knew it, I'll quickly sort the test files as well... |
@fsbraun I |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@filipweidemann Thank you so much for this nice PR!
Ofc, thanks for the merge as well :) |
@filipweidemann Released as version 4.0 🎉 |
@fsbraun lovely, thank you so much 🙏 |
Description
This PR adds support for the new djangoCMS 4.x.
It closes #221 and uses the outlined approach discussed there.
I also refactored the test setup and added the Mixin/Fixture of djangocms-text-ckeditor4 to support both djangoCMS 3 & 4.
All tests are green locally, I'd be happy to get this merged if everything is looking good to you @fsbraun :)
Related resources
Checklist
master
Slack to find a “pr review buddy” who is going to review my pull request.