[Resolves #468] Move clean_html import into clean methods

[danielsamuels]

This change allows the HTMLField to be used within a custom user model without causing a LookupError.

[coveralls]

Coverage increased (+0.03%) to 78.043% when pulling d980bb9 on danielsamuels:patch-1 into bba7d19 on divio:master.

[mbi]

Hello @danielsamuels 👋 I've been bitten a few times by #468 and I've stumbled upon this PR of yours. I'd like to reopen that issue and get it fixed. May I ask why you closed this PR? Was the fix not effective?

Thanks.

[fsbraun]

Hi @mbi ! Since the htmllib's sanitizer has been deprecated it is time to move to bleach as a sanitizer for djangocms-text-ckeditor. I'd suggest to refactor the imports together with this change. What do you think? Would you be able to support such a PR?

[mbi]

@fsbraun yes, I'll submit a PR as soon as I find a moment...

[fsbraun]

Since the discussion in #632 might take some time to resolve, does it make sense for now, to move

djangocms-text-ckeditor/djangocms_text_ckeditor/utils.py

Line 11 in 9ac4c15

from cms.models import CMSPlugin

from the top of the file into the get_plugins_from_text function - just as the other cms core import in that function?

djangocms-text-ckeditor/djangocms_text_ckeditor/utils.py

Lines 147 to 153 in 9ac4c15

	def get_plugins_from_text(text, regex=OBJ_ADMIN_RE):
	from cms.utils.plugins import downcast_plugins
	plugin_ids = plugin_tags_to_id_list(text, regex)
	plugins = CMSPlugin.objects.filter(pk__in=plugin_ids).select_related('placeholder')
	plugin_list = downcast_plugins(plugins, select_placeholder=True)
	return {plugin.pk: plugin for plugin in plugin_list}

I'd assume this would solve the issue? Also, it would be great to have a test to check this...

[mbi]

@fsbraun it absolutely solves the issue, I'm running a fork just to do that. I'll prepare a PR just for this issue, and I'll analyze how hard it'd be to actually test this.

[mbi]

@fsbraun here you go: #636. As mentioned in the PR, I couldn't manage to test this. If a test is strictly required, I'll need help on how to setup a custom user model within django-cms' app_help / testing mechanism. 🙏