Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use same icons in page tree state indicators and Manage verisons #302

Merged
merged 51 commits into from
Dec 21, 2022

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Dec 15, 2022

Description

This PR reuses the icons of the django CMS core (which are loaded anyways) for the "Manage Verions" admin view. This creates a more uniform look and feel.

Before (with djangocms-versioning icons):
Bildschirmfoto 2022-12-15 um 09 26 22

After (with django-cms core icons):
Bildschirmfoto 2022-12-15 um 09 27 59

Related resources: icons of django CMS core

Bildschirmfoto 2022-12-15 um 09 32 01

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

Add:		Patch edit pagecontent only for draft versions
Add:		Revert button for unpublished versions
Add:		Delete draft menu entry for pagecontents tree
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #302 (c61f1e4) into master (3e6fb53) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #302   +/-   ##
=======================================
  Coverage   86.91%   86.91%           
=======================================
  Files          30       30           
  Lines        1743     1743           
  Branches      269      269           
=======================================
  Hits         1515     1515           
  Misses        173      173           
  Partials       55       55           
Impacted Files Coverage Δ
djangocms_versioning/admin.py 88.76% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👏

@fsbraun fsbraun merged commit 5fe601b into django-cms:master Dec 21, 2022
@fsbraun fsbraun deleted the feat/state-indicators-cms-icons branch January 10, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants