-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use same icons in page tree state indicators and Manage verisons #302
Merged
fsbraun
merged 51 commits into
django-cms:master
from
fsbraun:feat/state-indicators-cms-icons
Dec 21, 2022
Merged
feat: Use same icons in page tree state indicators and Manage verisons #302
fsbraun
merged 51 commits into
django-cms:master
from
fsbraun:feat/state-indicators-cms-icons
Dec 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add: Patch edit pagecontent only for draft versions
Add: Revert button for unpublished versions
Add: Delete draft menu entry for pagecontents tree
…can_be_...` methods.
Codecov Report
@@ Coverage Diff @@
## master #302 +/- ##
=======================================
Coverage 86.91% 86.91%
=======================================
Files 30 30
Lines 1743 1743
Branches 269 269
=======================================
Hits 1515 1515
Misses 173 173
Partials 55 55
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
marksweb
requested changes
Dec 15, 2022
djangocms_versioning/templates/djangocms_versioning/admin/icons/manage_versions.html
Show resolved
Hide resolved
djangocms_versioning/templates/djangocms_versioning/admin/icons/preview.html
Show resolved
Hide resolved
djangocms_versioning/templates/djangocms_versioning/admin/icons/revert_icon.html
Outdated
Show resolved
Hide resolved
djangocms_versioning/templates/djangocms_versioning/admin/icons/unpublish_icon.html
Outdated
Show resolved
Hide resolved
djangocms_versioning/templates/djangocms_versioning/admin/icons/view.html
Outdated
Show resolved
Hide resolved
marksweb
approved these changes
Dec 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reuses the icons of the django CMS core (which are loaded anyways) for the "Manage Verions" admin view. This creates a more uniform look and feel.
Before (with djangocms-versioning icons):
After (with django-cms core icons):
Related resources: icons of django CMS core
templates/djangocms_versioning/admin/icons/
templates (before some icons had a independent templates)Checklist
master
Slack to find a “pr review buddy” who is going to review my pull request.