feat: Django 4.2, Django CMS 4.1.0rc2 compatibility, and version locking #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #326 +/- ##
==========================================
+ Coverage 90.55% 90.93% +0.37%
==========================================
Files 69 72 +3
Lines 2329 2536 +207
Branches 314 358 +44
==========================================
+ Hits 2109 2306 +197
- Misses 165 170 +5
- Partials 55 60 +5
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
fsbraun
changed the title
|
Just added ruff as linter link just as in #329 |
| ) | ||
| from djangocms_versioning.models import Version | ||
| from .constants import ARCHIVED, DRAFT, PUBLISHED, UNPUBLISHED, VERSION_STATES | ||
| from .models import Version |
Check notice
Code scanning / CodeQL
Cyclic import
…ing into fix/rc2_compat
…ing into fix/rc2_compat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds tests for Django 4.2 and mixins for django CMS'
GrouperModelAdminclass (new in 4.2rc2). It includes the version locking functionality. Version locking is activated by settingDJANGOCMS_VERSIONING_LOCK_VERSIONS = Truein the project settings.Documentation has been updated and tests have been added.
To stay DRY and avoid code repetition, the
djangocms_versioning.adminmodule has been slightly refactored.ExtendedListDisplayMixinencapsulates the extension of the change list view of versioned objects using django CMS 4's new config feature. Both versioned grouper admins and versioned content admins inherit it.Djangocms Versioning now supports both versioned grouper model admins and versioned content model admins. The latter are backwards compatible.
Related resources
Checklist
masterSlack to find a “pr review buddy” who is going to review my pull request.