Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: List DJANGOCMS_VERSIONING_LOCK_VERSIONS in settings #350

Merged
merged 8 commits into from
Sep 12, 2023

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Sep 12, 2023

Description

This PR updates the docs , specifically explicitly lists the DJANGOCMS_VERSIONING_LOCK_VERSIONS settings in settings.rst.

It also introduces a github action that builds the docs.

Related resources

  • #...
  • #...

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e6e3143) 90.93% compared to head (187c8ef) 90.93%.

❗ Current head 187c8ef differs from pull request most recent head e1096af. Consider uploading reports for the commit e1096af to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #350   +/-   ##
=======================================
  Coverage   90.93%   90.93%           
=======================================
  Files          72       72           
  Lines        2536     2536           
  Branches      357      357           
=======================================
  Hits         2306     2306           
  Misses        170      170           
  Partials       60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fsbraun fsbraun changed the title docs: List DJANGOCMS_VERSIONING_LOCK_VERSIONS in settings docs: List DJANGOCMS_VERSIONING_LOCK_VERSIONS in settings Sep 12, 2023
@vinitkumar vinitkumar merged commit 910ce03 into master Sep 12, 2023
81 checks passed
@vinitkumar vinitkumar deleted the docs/add-locking-to-settings branch September 12, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants