Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/use keyword arguments in admin render change form method #356

Merged
merged 2 commits into from
Oct 21, 2023
Merged

Bugfix/use keyword arguments in admin render change form method #356

merged 2 commits into from
Oct 21, 2023

Conversation

vipulnarang95
Copy link
Contributor

Description

Using keyword arguments in Render change form method for VersioningAdminMixin

added keyword arguments in render change form in VersioningAdminMixin
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8e045dd) 90.86% compared to head (349510a) 90.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #356   +/-   ##
=======================================
  Coverage   90.86%   90.86%           
=======================================
  Files          72       72           
  Lines        2530     2530           
  Branches      356      356           
=======================================
  Hits         2299     2299           
  Misses        170      170           
  Partials       61       61           
Files Coverage Δ
djangocms_versioning/admin.py 90.70% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @vipulnarang95. Good catch.

@fsbraun fsbraun merged commit c16c177 into django-cms:master Oct 21, 2023
joshyu pushed a commit to joshyu/djangocms-versioning that referenced this pull request Apr 2, 2024
fsbraun pushed a commit that referenced this pull request Apr 3, 2024
* feat: Provide additional information when sending publish/unpublish events (cherry-pick #348)

* fix:  Add keyword arguments in VersionAdminMixin render_change_form (cherry-pick #356)

---------

Co-authored-by: Josh Yu <joshyu@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants