fix: Consistent use of action buttons #392
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the use of action buttons ("Publish", "Unpublish", "Discard", "Archive") consistent:
Currently, for example, a user w/o publishing permission will not see a "Publish" button. After this PR they will see one (if the object is a draft) but it will be disabled.
This is also the behaviour of the core.
Additionally, the same rules apply for "archive" which so far did not check any conditions if the user can archive the object, and "unlock version" which so far had only hard-coded checks and did not use the conditions framework.
Related resources
_get_archive_link
does not check thecheck_archive
condition #391Checklist
master
Slack to find a “pr review buddy” who is going to review my pull request.