Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid duplication of placeholder checks for locked versions #393

Merged
merged 8 commits into from
Mar 28, 2024

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Mar 13, 2024

Description

djangocms-versioning adds default_checks to placeholders to avoid changing content of published objects. The checks for locked versions were added for every versioned model, but only need adding once.

This PR moves adding the check for locked versions from cms_config.py to apps.py, where it is only done once.

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.60%. Comparing base (f90c5b2) to head (0094662).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
+ Coverage   90.88%   91.60%   +0.71%     
==========================================
  Files          72       72              
  Lines        2546     2573      +27     
  Branches      361      366       +5     
==========================================
+ Hits         2314     2357      +43     
+ Misses        168      153      -15     
+ Partials       64       63       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fsbraun fsbraun requested a review from marksweb March 27, 2024 19:25
Copy link
Member

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fsbraun fsbraun merged commit b2d46f6 into django-cms:master Mar 28, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants